This repository has been archived by the owner on May 1, 2023. It is now read-only.
chore: refactored to organize routes and client #106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Plan for scanners/owasp-zap✅ Terraform Format: Plan: 0 to add, 1 to change, 0 to destroyShow planResource actions are indicated with the following symbols:
~ update in-place
Terraform will perform the following actions:
# aws_ecs_cluster.scanning_tools will be updated in-place
~ resource "aws_ecs_cluster" "scanning_tools" {
id = "arn:aws:ecs:ca-central-1:507252742351:cluster/scanning-tools"
name = "scanning-tools"
tags = {}
# (3 unchanged attributes hidden)
+ setting {
+ name = "containerInsights"
+ value = "enabled"
}
}
Plan: 0 to add, 1 to change, 0 to destroy.
─────────────────────────────────────────────────────────────────────────────
Saved the plan to: plan.tfplan
To perform exactly these actions, run the following command to apply:
terraform apply "plan.tfplan"
Releasing state lock. This may take a few moments...
|
maxneuvians
approved these changes
Sep 2, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactored the api so that components reside in their own route. This is needed to allow unique routes so that we don't clobber existing routes when using similar paths.
Also added a dev flag for the root_path so that we have consistency between local test and what's deployed to AWS. this can be removed once we migrate to scan-websites.alpha.canada.ca